Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I885 #886

Merged
merged 3 commits into from
Sep 19, 2021
Merged

I885 #886

merged 3 commits into from
Sep 19, 2021

Conversation

tlienart
Copy link
Owner

closes: #885

There was an issue when evaluating literate files with no code (or code cells that were effectively empty or just comments)

  1. the expressions for that code block would be empty, this had to be taken into account to avoid a 0-index error
  2. we still need to write an output file so that in the showall mode of Literate there would be nothing shown as opposed to an error saying that some file doesn't exist.

Here's the result now with the file mentioned in #885

Screenshot 2021-09-19 at 12 41 29

@tlienart tlienart merged commit 4c5697f into master Sep 19, 2021
luraess added a commit to eth-vaw-glaciology/course-101-0250-00 that referenced this pull request Sep 19, 2021
tlienart/Franklin.jl#886 now allows for standalone code comments to be correctly parsed in Franklin's Literate include.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on valid Literate file
1 participant