Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ongoing fixes while battle testing Literate integration #264

Merged
merged 9 commits into from
Oct 10, 2019
Merged

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Oct 9, 2019

Minor

  • dont show nothing
  • make output of class plaintext to avoid automatic highlighting from highlight
  • suppress output if last line finishes with ;
  • suppress output if last line is a statement that writes to stdout
  • adds LOCAL_PAGE_VARS["literate_only"] if set to true will assume that if there a literate insertion then it's the only source of code on the page and so uses literate to determine if code has changed in one shot; if it hasn't changed, freeze the code to skip eval; if it's not the only source of code, it should be set to false (but recommend that this not be the case... shouldn't blend too much)
  • more tests

Major

  • track literate files, process files which may call modified literate; this might only be used for minor changes but would be useful nonetheless

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #264 into master will increase coverage by 0.13%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   90.89%   91.02%   +0.13%     
==========================================
  Files          30       30              
  Lines        1504     1560      +56     
==========================================
+ Hits         1367     1420      +53     
- Misses        137      140       +3
Impacted Files Coverage Δ
src/JuDoc.jl 100% <ø> (ø) ⬆️
src/converter/md.jl 100% <100%> (+1.66%) ⬆️
src/converter/md_blocks.jl 98.4% <100%> (+0.8%) ⬆️
src/converter/lx.jl 96.52% <100%> (+0.31%) ⬆️
src/converter/lx_simple.jl 90.9% <100%> (+2.84%) ⬆️
src/misc_utils.jl 100% <100%> (ø) ⬆️
src/parser/html_blocks.jl 100% <100%> (+3.22%) ⬆️
src/jd_paths.jl 100% <100%> (ø) ⬆️
src/jd_vars.jl 100% <100%> (ø) ⬆️
src/misc_html.jl 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a025ab8...51e6034. Read the comment docs.

@tlienart tlienart changed the title Ongoing small fixes Ongoing fixes while battle testing Literate integration Oct 9, 2019
@tlienart tlienart marked this pull request as ready for review October 9, 2019 22:34
@tlienart tlienart mentioned this pull request Oct 9, 2019
67 tasks
@tlienart tlienart merged commit 9060bba into master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant