Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #250 (issue with reference links on first pass) #253

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Oct 7, 2019

This closes #250. The issue was simple, the function jd2html which is the barebone converter from markdown to html is called in add_rss_item passing a keyword indicating that the call is internal.

However jd2html didn't pass that indication to convert_md which then assumed that this was a new page it was on and, as a result, flushed out dictionaries including the dictionary of reference links. As a result when trying to fix links, JuDoc saw an empty reference dictionary and assumed that these links were not links after all and so just outputted them as such.

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #253 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.01%     
==========================================
  Files          29       29              
  Lines        1437     1436       -1     
==========================================
- Hits         1303     1302       -1     
  Misses        134      134
Impacted Files Coverage Δ
src/JuDoc.jl 100% <ø> (ø) ⬆️
src/manager/file_utils.jl 82.69% <ø> (-1.24%) ⬇️
src/converter/md.jl 98.29% <100%> (ø) ⬆️
src/converter/html.jl 96.77% <100%> (ø) ⬆️
src/converter/link_fixer.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523703d...ea1c5ac. Read the comment docs.

@tlienart tlienart merged commit 6ca011c into master Oct 7, 2019
@tlienart tlienart mentioned this pull request Oct 8, 2019
67 tasks
@tlienart tlienart deleted the linkfixerfix branch October 9, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown reference links
1 participant