Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS (fixes) #245

Merged
merged 9 commits into from
Oct 1, 2019
Merged

RSS (fixes) #245

merged 9 commits into from
Oct 1, 2019

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Oct 1, 2019

following validator comments, added and removed a few things.

Oh man the validator is happy

Screen Shot 2019-10-01 at 15 11 46

Now there's a few tests that need to be accordingly fixed...

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #245 into master will increase coverage by 0.17%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   89.97%   90.15%   +0.17%     
==========================================
  Files          29       29              
  Lines        1377     1381       +4     
==========================================
+ Hits         1239     1245       +6     
+ Misses        138      136       -2
Impacted Files Coverage Δ
src/manager/rss_generator.jl 93.33% <92.85%> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3336fb...4882e67. Read the comment docs.

@tlienart tlienart merged commit 83980a8 into master Oct 1, 2019
@tlienart tlienart deleted the rss branch October 9, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants