Fix crash if non-ASCII character precedes $ math #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit fixes a related issue, but during the prerendering KaTeX step. I split up the prerendering test so that I could test it locally, since I haven't been able to figure out node/highlight.js yet. |
|
The Travis 1.0 failure is real, but preexisting (as redirecting stderr/stdout to a IOBuffer is a 1.1 feature). I guess Travis wasn't testing this codepath because it's missing highlight.js; this change made the failure visible by removing that check for this branch. Maybe upgrading the minimum Julia version to 1.1 is reasonable? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a sequence like
“$x$”occurs (where the quotes are fancy quotes), then there would be aStringIndexError. This fixes the problem by callingprevindinstead of subtracting1.Since
previndwith the defaultn=1can't return a negative number, I've also removed the else branch here since it's only setting 0 to 0.