Fix nested table of contents HTML #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and thanks so much for this! I've had a brief look and it looks great to me; it's a bit late here so I'll have a more in depth look tomorrow and will merge. Thanks a lot for taking the time. |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 88.15% 88.16% +<.01%
==========================================
Files 28 28
Lines 1317 1318 +1
==========================================
+ Hits 1161 1162 +1
Misses 156 156
Continue to review full report at Codecov.
|
|
Of course, thank you so much for making this package! |
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML nested lists need to have the sublists contained within the parent <li>. This PR changes the TOC generation to perform this nesting, as well as to detect the highest heading level (so as not to generate an empty H1 entry if the page contains no H1 headings).
Before this PR, note how the numbering is strange (because the <ol> tags are not contained within the list item, so essentially numbering is reset to 1 whenever an <ol> tag is seen, instead of nesting):
After this PR, the problem is fixed: