Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for commonmark style links #214

Merged
merged 2 commits into from
Sep 6, 2019
Merged

support for commonmark style links #214

merged 2 commits into from
Sep 6, 2019

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Sep 5, 2019

indirect links are now supported so stuff like

[link] ... 
[link]: url

or

[link][] ...
[link]: url

or

[link][id]
[id]: url

all are roughly tested but I should probably get a night sleep on it before merging. Probably need to assess a few things:

  • does it work with images (I think it should but haven't tried)
  • does the Gruber's syntax for link names work in Julia? so like [a link](url "link title") if not, just document it and add support only if explicitly requested.

@tlienart tlienart changed the title support for gruber style links support for commonmark style links Sep 5, 2019
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.19%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #214     +/-   ##
=========================================
- Coverage      87%   86.81%   -0.2%     
=========================================
  Files          27       28      +1     
  Lines        1131     1160     +29     
=========================================
+ Hits          984     1007     +23     
- Misses        147      153      +6
Impacted Files Coverage Δ
src/converter/md_utils.jl 100% <ø> (ø) ⬆️
src/manager/file_utils.jl 82.69% <ø> (ø) ⬆️
src/JuDoc.jl 100% <ø> (ø) ⬆️
src/converter/html.jl 95.65% <100%> (+0.19%) ⬆️
src/converter/fixer.jl 78.57% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea04031...57ae143. Read the comment docs.

…d more thorough tests for indirect links, test fixes to account for KaTeX update to v11
@tlienart tlienart mentioned this pull request Sep 6, 2019
27 tasks
@tlienart tlienart merged commit 0856352 into master Sep 6, 2019
@tlienart tlienart deleted the links branch September 27, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant