Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message in eval block (see #186) #187

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Add error message in eval block (see #186) #187

merged 2 commits into from
Jul 8, 2019

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Jul 8, 2019

#186

  • shows the error so that:
```julia:script/test
sqrt(-1)
```
\output{script/test}

gives

<pre><code class="language-julia">sqrt(-1)</code></pre> <pre><code>There was an error running the code: DomainError(-1.0, "sqrt will only return a complex result if called with a complex argument. Try sqrt(Complex(x)).").</code></pre>

which can help for debugging.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          26       26           
  Lines        1037     1037           
=======================================
  Hits          903      903           
  Misses        134      134
Impacted Files Coverage Δ
src/converter/md_blocks.jl 96.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87924b5...7639d8c. Read the comment docs.

@tlienart tlienart merged commit e4c4312 into master Jul 8, 2019
@tlienart tlienart deleted the i186 branch July 8, 2019 14:41
@tlienart tlienart mentioned this pull request Jul 9, 2019
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant