Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlight install command #178

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

cserteGT3
Copy link
Contributor

@cserteGT3 cserteGT3 commented Jun 16, 2019

I've experienced some issues with the highlight.js package installation, and finally this command solved it:

[sudo] npm install --save -g highlight.js

So --save is needed (in my case at least). I'm not experienced with node.js at all, so it's possible that it's not a perfect solution.
Sources:
stackoverflow, meteor issue.

Edit: I think this caused #174 (at least the node.js part).

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          23       23           
  Lines         966      966           
=======================================
  Hits          845      845           
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a402f20...30d449c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          23       23           
  Lines         966      966           
=======================================
  Hits          845      845           
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a402f20...30d449c. Read the comment docs.

@tlienart
Copy link
Owner

Thanks a lot for this!

@tlienart tlienart merged commit e84934e into tlienart:master Jun 17, 2019
@mbaz
Copy link

mbaz commented Jun 19, 2019

I had the opposite problem:

$ sudo npm install --save -g highlight.js
+ [email protected]
updated 1 package in 0.384s

$ node -e "require('highlight.js')"
internal/modules/cjs/loader.js:670
    throw err;
    ^

Error: Cannot find module 'highlight.js'
[...]

$ sudo npm install -g highlight.js
+ [email protected]
updated 1 package in 0.428s
$ node -e "require('highlight.js')"
$

@cserteGT3
Copy link
Contributor Author

To be precise, when I tried this (--save) on another Windows machine, I couldn't get it to work for first try. It worked only after running this and the original command couple of times, so I'm not sure that this is the way to do the installation. (On my laptop, this worked for the first time).
Maybe we should roll back to the original command and mention the linked posts? Then everyone can figure out if encounters the error.

(Btw. I'm thinking on switching to linux. I'm starting to hate windows :D )

@tlienart
Copy link
Owner

Hmm shoot, I also did it like @mbaz and it worked.

I guess in want of a clear explanation, I'll change the doc slightly to say that the former should work, and that the --save may help otherwise e.g. on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants