wrong sitemap for 404.html

[fkastner]

Another sitemap issue:
the 404.html appears as <loc>https://tlienart.github.io/FranklinTemplates.jl/404/index.html</loc>.
I think this is because the file is special cased in form_output_path

Franklin.jl/src/manager/dir_utils.jl

Lines 29 to 45 in caa1518

	function form_output_path(base::AS, file::AS, case::Symbol)
	# .md -> .html for md pages:
	case == :md && (file = change_ext(file))
	outbase = _out_path(base)
	if case in (:md, :html)
	# file is index.html or 404.html or in keep_path --> keep the path
	# file is page.html --> .../page/index.html
	fname = splitext(file)[1]
	if fname ∉ ("index", "404") && !endswith(fname, "/index") && !_keep_path(base, fname)
	file = joinpath(fname, "index.html")
	end
	end
	outpath = joinpath(outbase, file)
	outdir = splitdir(outpath)[1]
	isdir(outdir) || mkpath(outdir)
	return outpath
	end

and the sitemap generator does not know about this.

I think the most elegant way to handle this would probably be to add the file to keep_path instead of the current special handling. But that would be a breaking change.

[fkastner]

Actually the issue still persists for 404.md pages (as in some of the templates).
Do you think your fix can be adapted to handle those as well?

[tlienart]

🤔 crap that shouldn't have happened. Thanks for the report, I'll look into it