Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-workmail: add page #9058

Merged
merged 3 commits into from
Oct 16, 2022
Merged

aws-workmail: add page #9058

merged 3 commits into from
Oct 16, 2022

Conversation

ShivamJoker
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.8.2

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 15, 2022
@kbdharun kbdharun mentioned this pull request Oct 15, 2022
Open
kbdharun
kbdharun approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@ShivamJoker
Copy link
Contributor Author

@navarroaxel can you also review and approve it?

@kbdharun
Copy link
Member

navarroaxel can you also review and approve it?

I will request his review, If possible can you add Hindi translation to subcommand-mention?

Thanks in advance

@kbdharun kbdharun requested a review from navarroaxel October 16, 2022 07:09
@ShivamJoker
Copy link
Contributor Author

Sure thing.

@ShivamJoker
Copy link
Contributor Author

@kbdharun what will be the format of commit message?

@kbdharun
Copy link
Member

kbdharun commented Oct 16, 2022 •
edited
Loading

@kbdharun what will be the format of commit message?

subcommand-mention: add Hindi translation

This would be the format of the commit message as well as the PR title.

@navarroaxel navarroaxel merged commit 5a7d381 into tldr-pages:main Oct 16, 2022
@ShivamJoker ShivamJoker deleted the feat/aws-amplify branch October 16, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShivamJoker @kbdharun @navarroaxel