Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-lightsail: add page #8934

Merged
merged 4 commits into from
Oct 11, 2022
Merged

aws-lightsail: add page #8934

merged 4 commits into from
Oct 11, 2022

Conversation

ShivamJoker
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.8.2

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 11, 2022
@tldr-bot

This comment was marked as outdated.

Sign in to view
@ShivamJoker
Copy link
Contributor Author

Mentioned in #5653

@navarroaxel navarroaxel mentioned this pull request Oct 11, 2022
Open
navarroaxel
navarroaxel reviewed Oct 11, 2022
View reviewed changes
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
pages/common/aws-lightsail.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from kbdharun October 11, 2022 10:21
@navarroaxel
Copy link
Collaborator

@ShivamJoker you don't need to keep the PR in sync main because the pages are independent.

@ShivamJoker
Copy link
Contributor Author

@ShivamJoker you don't need to keep the PR in sync main because the pages are independent.

Got it. Thanks!

kbdharun
kbdharun approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@navarroaxel I can't merge it as CLA workflow is waiting

@navarroaxel
Copy link
Collaborator

@kbdharun I think it's a bug with the CLA check, because the author already merged #8825, and the CLA passed when this PR were created, otherwise we had the bot's comment. I'll force the merge.

@navarroaxel navarroaxel merged commit d344897 into tldr-pages:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShivamJoker @tldr-bot @navarroaxel @kbdharun