Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-s3-ls: add page #8619

Merged
merged 1 commit into from
Oct 9, 2022
Merged

aws-s3-ls: add page #8619

merged 1 commit into from
Oct 9, 2022

Conversation

tales-aparecida
Copy link
Contributor

@tales-aparecida tales-aparecida commented Oct 2, 2022 •
edited
Loading

Hello! I was a little bit concerned about how the wording, as AWS S3 uses "prefixes" and "objects" instead of "folders" and "files".

Screenshot of the command tldr --render pages/common/aws-s3-ls.md

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Tested using aws-cli/1.23.12 Python/3.6.15 Linux/5.13.0-41-generic botocore/1.25.12

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 2, 2022
navarroaxel
navarroaxel reviewed Oct 7, 2022
View reviewed changes
@tales-aparecida
Copy link
Contributor Author

tales-aparecida commented Oct 8, 2022 •
edited
Loading

Rebased on top of main and resolved comments

navarroaxel
navarroaxel reviewed Oct 8, 2022
View reviewed changes
@navarroaxel navarroaxel requested a review from kbdharun October 8, 2022 20:51
@navarroaxel navarroaxel changed the title aws-s3-ls: add page (#8406) aws-s3-ls: add page Oct 8, 2022
@navarroaxel
Copy link
Collaborator

Rebased on top of main and resolved comments

You don't need to rebase, tldr-pages are independent pages. Actually only changes on the CI can affect PRs.

kbdharun
kbdharun approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 9a0ae44 into tldr-pages:main Oct 9, 2022
@shermanhui shermanhui mentioned this pull request Oct 21, 2022
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@kbdharun kbdharun kbdharun approved these changes

@CleanMachine1 CleanMachine1 Awaiting requested review from CleanMachine1

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tales-aparecida @navarroaxel @kbdharun