Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rds: add page #6547

Merged
merged 8 commits into from
Oct 7, 2021
Merged

aws-rds: add page #6547

merged 8 commits into from
Oct 7, 2021

Conversation

258204
Copy link
Collaborator

@258204 258204 commented Sep 18, 2021 •
edited
Loading

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot

This comment has been minimized.

Sign in to view
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Sep 18, 2021
@navarroaxel navarroaxel changed the title aws-rds: added page aws-rds: add page Sep 18, 2021
@tldr-bot

This comment has been minimized.

Sign in to view
navarroaxel
navarroaxel reviewed Sep 18, 2021
View reviewed changes
pages/common/aws-rds.md Outdated Show resolved Hide resolved
pages/common/aws-rds.md Outdated Show resolved Hide resolved
258204 and others added 3 commits September 17, 2021 22:45
navarroaxel
navarroaxel reviewed Sep 18, 2021
View reviewed changes
pages/common/aws-rds.md

- Modify an RDS instance:

`aws rds modify-db-instance --db-instance-identifier {{instance_identifier}} {{parameters}} --apply-immediately`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this parameters placeholder is too generic, maybe example about modify an instance characteristic is better.

@258204 258204 mentioned this pull request Sep 18, 2021
Open
sbrl
sbrl reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @258204! I've left some comments below for you to review.

pages/common/aws-rds.md Outdated Show resolved Hide resolved
pages/common/aws-rds.md Outdated Show resolved Hide resolved
pages/common/aws-rds.md Outdated Show resolved Hide resolved
pages/common/aws-rds.md Outdated Show resolved Hide resolved
pages/common/aws-rds.md Outdated Show resolved Hide resolved
@navarroaxel @sbrl
Apply suggestions from code review
67b10a7 
Co-authored-by: Starbeamrainbowlabs <[email protected]>
sbrl
sbrl approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after @navarroaxel's comment is addressed. Thanks, @258204!

@navarroaxel navarroaxel merged commit 5826e30 into tldr-pages:main Oct 7, 2021
@258204 258204 deleted the aws-rds branch October 10, 2021 23:50
@navarroaxel navarroaxel mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@258204 @tldr-bot @navarroaxel @sbrl