Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmcli: add page #5876

Merged
merged 6 commits into from
May 10, 2021
Merged

mmcli: add page #5876

merged 6 commits into from
May 10, 2021

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 3, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

The 2 example commands are derived from the following documentation:
https://wiki.pine64.org/wiki/PinePhone_FAQ#SMS

Just thought it'd be nice to have quick access to them via tldr.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thought it'd be nice to have quick access to them via tldr.

Definitely!

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 3, 2021
pages/linux/mmcli.md Outdated Show resolved Hide resolved
pages/linux/mmcli.md Outdated Show resolved Hide resolved
pages/linux/mmcli.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented May 3, 2021

CLA assistant check
All committers have signed the CLA.

@SethFalco
Copy link
Member Author

Sorry for the commit spam, I wanted to commit your suggestions using the UI since it'd save me from having to co-author manually, but I wasn't sure how to accept multiple suggestions at once. ^-^'

@bl-ue
Copy link
Contributor

bl-ue commented May 3, 2021

@SethFalco the CLA isn't working because the email address that you used for the last commit ([email protected]) isn't added to your GitHub account. To fix this, you can either:

  1. Change the email you used for the commit† to one of the emails attached to your GitHub account,

  2. Or, preferably (and much easier), add the email you used for this commit ([email protected]) to your GitHub account.

†To change the email address of the last commit, run this command:

git commit --amend --author="Seth Falco <[email protected]>"

@SethFalco
Copy link
Member Author

SethFalco commented May 3, 2021

Sorry about that, was getting rid of old email addresses. ^-^'
I'll just add it back to my account and remove it again once this has been merged since multiple of the commits here used [email protected]; should've updated my local git config sooner.

@bl-ue
Copy link
Contributor

bl-ue commented May 3, 2021

You know, I don't think you should do that. It might cause weird CLA issues in the future with other PRs or something like that. Instead, run the command I mentioned, in option number 2.

@SethFalco
Copy link
Member Author

SethFalco commented May 3, 2021

You know, I don't think you should do that. It might cause weird CLA issues in the future with other PRs or something like that. Instead, run the command I mentioned, in option number 2.

I can do that if you'd like. If that may indeed cause problems though, then I think it'd be a flaw with the bot, since deleting email addresses is common enough that people may not even have access to addresses they may have used to commit in the past.

pages/linux/mmcli.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from marchersimon May 4, 2021 12:15
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SethFalco

@navarroaxel navarroaxel requested a review from nicokosi May 4, 2021 12:20
@marchersimon marchersimon merged commit b575ffe into tldr-pages:main May 10, 2021
@SethFalco SethFalco deleted the mmcli branch May 18, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants