Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborator: @ivanhercaz #3691

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Add collaborator: @ivanhercaz #3691

merged 1 commit into from
Dec 28, 2019

Conversation

zlatanvasovic
Copy link
Contributor

Closes #3690

@sbrl
Copy link
Member

sbrl commented Dec 24, 2019

Erm this is a bit presumptuous, @zdroid. I recommend waiting until they accept the invitation, and then open the PR to add them. What happens if they say no?

@sbrl sbrl added the community Issues/PRs dealing with role changes and community organization. label Dec 24, 2019
@zlatanvasovic
Copy link
Contributor Author

zlatanvasovic commented Dec 24, 2019

@sbrl I took this comment as a "yes".

@ivanhercaz
Copy link
Collaborator

Wow! That's really awesome. Thank you very much for this proposal.

Erm this is a bit presumptuous, @zdroid. I recommend waiting until they accept the invitation, and then open the PR to add them. What happens if they say no?

Don't worry @sbrl. I am really happy with this invitation and I see this as an opportunity to contribute a bit more in a different way to this project. I didn't reply the invitation until now but...

@sbrl I took this comment as a "yes".

... this is true hehe. I understand the comment isn't valid as an official acceptance, but please keep calm about it because I really like atmosphere of this project and how all of you collaborate to make it better.

Really awesome! Again, thank you very much!

@waldyrious
Copy link
Member

@sbrl I took this comment as a "yes".

That's fair, @zdroid, but because not everyone is able to keep track of all conversations, it would have been nice to mention that comment either in the opening message of this PR, or in the corresponding issue (#3690). Otherwise it would become quite difficult to track down the conversation sequence a few months or years down the road (and we do need to dig up old conversations every now and then, so let's make our own lives easier when we can! 😄)

@andrik
Copy link
Collaborator

andrik commented Dec 26, 2019

Welcome aboard @ivanhercaz

It's really nice to see more people getting involved with tldr

@waldyrious
Copy link
Member

It's really nice to see more people getting involved with tldr

Agreed — and especially so for someone with experience in the Wikimedia world, whose community has managed to build a very permissive collaboration culture, similar to what we're trying to implement in tldr-pages (case in point!).

Welcome @ivanhercaz! Make sure to get acquainted with the project governance guidelines and the maintainer's guide! 😉

@sbrl
Copy link
Member

sbrl commented Dec 27, 2019

Hey, awesome @ivanhercaz! Invite sent :D

You've got experience with the Wikimedia world? Nice!

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this when @ivanhercaz accepts the invite.

@ivanhercaz
Copy link
Collaborator

Welcome aboard @ivanhercaz

It's really nice to see more people getting involved with tldr

Thank you very much! It is a pleasure to be in this ship @andrik ❤️

It's really nice to see more people getting involved with tldr

Agreed — and especially so for someone with experience in the Wikimedia world, whose community has managed to build a very permissive collaboration culture, similar to what we're trying to implement in tldr-pages (case in point!).

Welcome @ivanhercaz! Make sure to get acquainted with the project governance guidelines and the maintainer's guide!

Thank you for your words and the welcome, @waldyrious. I hope to contribute as much as I can within my possibilities. Before to perform any maintenance task I will read carefully the project governance and the maintainer's guide documents.

Hey, awesome @ivanhercaz! Invite sent :D

You've got experience with the Wikimedia world? Nice!

Thank you, @sbrl! Yes, I am Wikimedia since some years. If sometimes I can help you with something, ask me! I will do everything in my hands.

Let's merge this when @ivanhercaz accepts the invite.

Accepted!

Again, thank you very much to everyone and specially to @zdroid for being attentive to my activity and propose me as collaborator ❤️.

@zlatanvasovic zlatanvasovic merged commit ef24c5a into master Dec 28, 2019
@zlatanvasovic zlatanvasovic deleted the zdroid-ivanhercaz branch December 28, 2019 17:42
@zlatanvasovic
Copy link
Contributor Author

Welcome aboard! 🚢 🇮🇹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collaborator: @ivanhercaz
6 participants