MAINTAINERS.md: Add @andrik & @Aracki as repos collaborators #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aracki
added
the
community
owenvoke
approved these changes
May 10, 2019
waldyrious
approved these changes
May 10, 2019
There was a problem hiding this comment.
Looks good :) this diff won't conflict with #2258, so we can merge it now.
|
@waldyrious, I assumed that #2988 (comment) and #2988 (comment) were the confirmations. 🤔 |
|
I accepted it. |
|
The invites are only sent once the contributor(s) agrees with the proposal, as @sbrl's comments in #2988 attest. What I meant was public confirmations that the invites have been accepted, as @Aracki did above. That's not a big deal, of course, but it helps us make sure that the closing of the issue only happens once all the steps are completed (the last one being the merge of this PR). |
|
I accepted it |
schneiderl
approved these changes
May 10, 2019
|
Thanks guys! |
waldyrious
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added @andrik & @Aracki as repository collaborators.
Closes #2988.