Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby version managers in pt-BR #2860

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Ruby version managers in pt-BR #2860

merged 3 commits into from
Apr 2, 2019

Conversation

andrik
Copy link
Collaborator

@andrik andrik commented Apr 1, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@owenvoke owenvoke added the translation Issues requesting translating pages from English to other languages. label Apr 1, 2019
schneiderl
schneiderl requested changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for the PR.
Just left one comment with a opinion about one of the descriptions.
Please take a look to see if you agree with it.

Other than that, it looks great to me 👍

sbrl
sbrl approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me once @schneiderl's comment is addressed :-)

@sbrl sbrl merged commit 9cdab90 into tldr-pages:master Apr 2, 2019
@andrik andrik deleted the ruby_version_managers_pt_br branch April 16, 2019 01:28
@sbrl sbrl mentioned this pull request May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneiderl schneiderl schneiderl requested changes

@owenvoke owenvoke owenvoke approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrik @owenvoke @sbrl @schneiderl