waitress-serve: add page #2451
Merged
waitress-serve: add page #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build for this PR has failed with the following error(s): Please fix the error(s) and push again. |
sbrl
reviewed
Oct 15, 2018
pages/common/waitress-serve.md
Outdated
|
|
||
| > Pure Python WSGI HTTP Server. | ||
|
|
||
| - Run Python web app: |
There was a problem hiding this comment.
Perhaps Run a Python.... would read better?
sbrl
requested changes
Oct 15, 2018
There was a problem hiding this comment.
Thanks for the new page, @MasterOdin! I've left some comments below for you to review.
pages/common/waitress-serve.md
Outdated
|
|
||
| `waitress-serve --listen={{localhost}}:{{8080}} {{import.path:wsgi_func}}` | ||
|
|
||
| - Start waitress on Unix socket: |
There was a problem hiding this comment.
Perhaps ...on a Unix domain socket would read better?
pages/common/waitress-serve.md
Outdated
|
|
||
| `waitress-serve --call {{import.path.wsgi_factory}}` | ||
|
|
||
| - Set URL scheme to https: |
There was a problem hiding this comment.
Perhaps Set the URL scheme.... would read better?
owenvoke
approved these changes
Oct 16, 2018
owenvoke
added
the
new command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page for waitress's CLI tool
waitress-serve.The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.