Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew-cask: add cask upgrade #2057

Merged
merged 2 commits into from
Apr 6, 2018
Merged

brew-cask: add cask upgrade #2057

merged 2 commits into from
Apr 6, 2018

Conversation

Lorwp
Copy link

@Lorwp Lorwp commented Apr 6, 2018

Brew Cask has had a proper upgrade command since Homebrew/brew#3396


- The page (if new), does not already exist in the repo. N/A

- The page (if new), has been added to the correct platform folder:
common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.
N/A

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

Brew Cask has had a proper upgrade command since Homebrew/brew#3396
@agnivade agnivade changed the title brew-cask: Add cask upgrade brew-cask: add cask upgrade Apr 6, 2018
@agnivade agnivade added the page edit Changes to an existing page(s). label Apr 6, 2018
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have one comment.

@@ -18,9 +18,9 @@

`brew cask outdated`

- Upgrade an installed cask to its latest version:
- Upgrade all installed casks to their latest version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the example from upgrading a single cask to upgrading all casks. I would like to keep it to "upgrading a single cask".

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 👍

@owenvoke owenvoke merged commit ea368f7 into tldr-pages:master Apr 6, 2018
@Lorwp Lorwp deleted the caskupgrade branch April 6, 2018 07:46
lamar-frankie pushed a commit to lamar-frankie/tldr that referenced this pull request Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants