Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ce: add page #13354

Merged
merged 1 commit into from
Aug 5, 2024
Merged

aws-ce: add page #13354

merged 1 commit into from
Aug 5, 2024

Conversation

debghs
Copy link
Collaborator

@debghs debghs commented Aug 4, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@debghs debghs requested a review from spageektti as a code owner August 4, 2024 18:05
@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Aug 4, 2024
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun mentioned this pull request Aug 5, 2024
@kbdharun kbdharun merged commit d3e4a56 into tldr-pages:main Aug 5, 2024
4 checks passed
@sebastiaanspeck
Copy link
Member

There seems to be an issue with this page; the URL to which it refers does not exist and the commands itself cannot be found online as well. Eventually I found out that the subcommands do exist, but they are prefixed with aws accessanalyzer: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/accessanalyzer/index.html?highlight=accessanalyzer

@debghs can you confirm that this page is outdated and should be updated to be aws accessanalyzer?

@debghs
Copy link
Collaborator Author

debghs commented Sep 18, 2024

Yeah, this page is definitely outdated, which is weird. But how did you track this down?

@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Sep 18, 2024

Yeah, this page is definitely outdated, which is weird. But how did you track this down?

Because somebody, in another issue, mentioned this URL resulted in a 404. @debghs can you open a PR to fix this?

@debghs debghs deleted the aws-ce branch September 18, 2024 15:54
@debghs
Copy link
Collaborator Author

debghs commented Sep 18, 2024

@sebastiaanspeck, please check out #13745.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants