Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pages*: fix small typos #11850

Merged
merged 4 commits into from
Dec 27, 2023
Merged

pages*: fix small typos #11850

merged 4 commits into from
Dec 27, 2023

Conversation

vitorhcl
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages. labels Dec 26, 2023
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.it/linux/zathura.md is outdated, based on the command contents itself.
  • The page pages.ko/common/chisel.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.it/linux/zathura.md is outdated, based on the command contents itself.
  • The page pages.ko/common/chisel.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.it/linux/zathura.md is outdated, based on the command contents itself.
  • The page pages.ko/common/chisel.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.it/linux/zathura.md is outdated, based on the command contents itself.
  • The page pages.ko/common/chisel.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

blueskyson
blueskyson approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Thanks for contribution.

kbdharun
kbdharun approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes.

@kbdharun kbdharun merged commit 61405c6 into tldr-pages:main Dec 27, 2023
@vitorhcl vitorhcl deleted the typos branch December 27, 2023 11:09
@acuteenvy acuteenvy removed their request for review December 27, 2023 14:33
@vitorhcl vitorhcl mentioned this pull request Dec 29, 2023
Closed
sbrl
sbrl reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this has already been merged, but I have found a number of issues with this PR.

pages/android/bugreportz.md
@@ -12,7 +12,7 @@

`bugreportz -p`

- Show the version of `bugreportz`:
- Display version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original wording was better here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrl for help and version descriptions we prefer using this generic wording in most cases to be uniform with other pages (https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#help-and-version-commands). We still suggest verbose descriptions for descriptions like Display help for a subcommand:, etc.

pages/linux/genid.md
@@ -9,7 +9,7 @@

- Generate a UUIDv5 using a namespace UUID and a specific name:

`genid uuidv5 {{{ce598faa-8dd0-49ee-8525-9e24fff71dca}}} {{name}}`
`genid uuidv5 {{ce598faa-8dd0-49ee-8525-9e24fff71dca}} {{name}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone on Windows with mingw check this please? I suspect this might be a bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda curious, isn't this a Linux-specific page, is testing on Windows required (if so I can do it now)?

@kbdharun kbdharun mentioned this pull request Dec 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl left review comments

@kbdharun kbdharun kbdharun approved these changes

@gutjuri gutjuri gutjuri approved these changes

@blueskyson blueskyson blueskyson approved these changes

@tansiret tansiret Awaiting requested review from tansiret tansiret is a code owner

@waldyrious waldyrious Awaiting requested review from waldyrious

@isaacvicente isaacvicente Awaiting requested review from isaacvicente isaacvicente is a code owner

@IMHOJEONG IMHOJEONG Awaiting requested review from IMHOJEONG IMHOJEONG is a code owner

@mebeim mebeim Awaiting requested review from mebeim mebeim is a code owner

@Magrid0 Magrid0 Awaiting requested review from Magrid0 Magrid0 is a code owner

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

@kant kant Awaiting requested review from kant kant is a code owner

@sebastiaanspeck sebastiaanspeck Awaiting requested review from sebastiaanspeck

Assignees
No one assigned
Labels
page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitorhcl @tldr-bot @sbrl @gutjuri @kbdharun @blueskyson