style-guide: modify grouping placeholders section #11723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kbdharun
approved these changes
Dec 11, 2023
kbdharun
changed the title
giladAlboher
approved these changes
Dec 11, 2023
sebastiaanspeck
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple pages where more than 5 possible argument values are separated with
|. (e.g. here)However, the style-guide currently states that if there are more than 5 possible values, we should use
...after the last (5th?) item.As this is 1. not how we do things in practice and 2. too restrictive (e.g. if there are 6 possible values, you'd be forced to write
...INSTEAD of the last value), I propose to change this from a hard rule to a recommendation.Also, #11146 has a checkbox that is somehow related (
Document how multiple examples can be concatenated and separated with |)