-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-s3-website: add page #11642
aws-s3-website: add page #11642
Conversation
Add an initial description of the local options for aws s3 website command.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to tldr and thanks for your contribution. I have some suggestions for this page.
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Thanks for your suggestions. Looking forward to continue contributing to this great project. |
Co-authored-by: Lena <[email protected]>
@Isaac-Carrascal Was this PR accidentally closed? |
@kbdharun Oops, sorry. I am new to this. Should I keep it open? I thought the change was made. What I should do? |
pages/common/aws-s3-website.md
Outdated
- Configure a bucket as a static website: | ||
|
||
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}}` | ||
|
||
- Configure an error page for the website: | ||
|
||
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}} --error-document {{error.html}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Configure a bucket as a static website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}}` | |
- Configure an error page for the website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}} --error-document {{error.html}}` | |
- Configure a bucket as a static website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{path/to/index.html}}` | |
- Configure an error page for the website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{path/to/index.html}} --error-document {{path/to/error.html}}` |
I know nothing about s3, but I suspect that the command expects a file path in the specified locations. Is that correct? If that's the case, we can spell it out in the tldr page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I am pretty sure it doesn't require path, will manually check it and get back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For bucket name, we don't need a trailing backslash, other than that, this PR is GTG.
- Configure a bucket as a static website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}}` | |
- Configure an error page for the website: | |
`aws s3 website {{s3://bucket-name/}} --index-document {{index.html}} --error-document {{error.html}}` | |
- Configure a bucket as a static website: | |
`aws s3 website {{s3://bucket-name}} --index-document {{index.html}}` | |
- Configure an error page for the website: | |
`aws s3 website {{s3://bucket-name}} --index-document {{index.html}} --error-document {{error.html}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after the suggestion
Add an initial description of the local options for aws s3 website command.
common
,linux
,osx
,windows
,sunos
,android
, etc.