-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLIENT-SPECIFICATION: add automatic platform detection suggestion, fix Markdown syntax #11523
Conversation
Signed-off-by: K.B.Dharun Krishna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list it as a supported platform in
--platform
option
Where do you think it should be listed?
Co-authored-by: Lena <[email protected]>
Since you merged #10730, we should probably bump the version. |
Agreed, I am planning to include this suggestion too (for this one we don't need to wait as long as previous PR as this isn't a required change) in the 2.1 version. Btw, Version bump is only necessary when we update the changelog will do it next week. Until then I will keep this PR open for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got a couple of comments on this - looks like a good update to the spec!
Can't believe that the spec I wrote some time ago is still alive and kicking lol :P
- [v1.0, January 23rd 2019](https://github.com/tldr-pages/tldr/blob/v1.0/CLIENT-SPECIFICATION.md) (deprecated) ([#2706](https://github.com/tldr-pages/tldr/pull/2706)) | ||
- Initial release. | ||
|
||
- Unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog will need updating before this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will update the changelog and will merge this PR tomorrow (will prepare the release notes too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated the changelog. Now, I will work on the release notes (which would be pretty small for this release) and then the new release is GTG.
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Yeah, that's some incredible work you did ❤️ publishing the initial spec and maintaining it throughout time. I am still fascinated by the professional wording and references to RFCs, etc in our client specification. |
Co-authored-by: Starbeamrainbowlabs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Co-authored-by: Sebastiaan Speck <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: Lena <[email protected]>
Changes
markdown-lint
errors.pages
directory.