GraphQL dependency update (0.8.*)

[mario-jerkovic]

I want to resolve #3 by updating library code as the new GraphQL 0.8.* has a breaking change:

A resolve function's info.fieldASTs value has been renamed to info.fieldNodes (#554)

[tjmehta]

Checking this out soon!
On Mon, Nov 21, 2016 at 9:42 AM Mario Jerkovic [email protected]
wrote:

Updated code as the new GraphQL 0.8.* has a breaking change:

A resolve function's info.fieldASTs value has been renamed to

info.fieldNodes (#554) graphql/graphql-js#554

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

• Updated info keys to reflect changes on updated graphQL dependencies
• Code cleanup

File Changes

• M index.js
  https://github.com/tjmehta/graphql-parse-fields/pull/4/files#diff-0
  (40)
• M package.json
  https://github.com/tjmehta/graphql-parse-fields/pull/4/files#diff-1
  (2)

Patch Links:

• https://github.com/tjmehta/graphql-parse-fields/pull/4.patch
• https://github.com/tjmehta/graphql-parse-fields/pull/4.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAnFF9ifmThr03vcSN_C8F9OdD6kHYVQks5rAdgOgaJpZM4K4fbN
.

[tjmehta]

Wow this kind've sucks. I wish GraphQL used semver. I'll have to think about this a bit. I could release a breaking change myself and just put a note in the readme to use 2.x.x for graphql@^0.8.x.

Thoughts?

[mario-jerkovic]

Maybe it's better to just have an additional condition that checks for presence of fieldASTs or fieldNodes keys. That way you will keep the compatibility with GraphQL 0.7.*

[tjmehta]

@mario-jerkovic, great idea. Seems obvious in hindsight haha.. I think I jumped to a conclusion too quickly. Will take over this PR implement compatibility w/ both, fix the tests, and release soon :)

[tjmehta]

continuing work in #5

[tjmehta]

Added support in [email protected]