fix domain crash #573
Closed
fix domain crash #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix doamin crash
|
@LiLinghui Would this PR resolve this (#586) issue I filed around the fact that edge crashes when using appDomains? |
|
@mmanela yes |
|
@tjanczuk Can you take a look at this PR? This will resolve possibly multiple open issues. |
agracio
pushed a commit
to agracio/edge-js
that referenced
this pull request
Sep 4, 2017
agracio
pushed a commit
to agracio/edge-js
that referenced
this pull request
Sep 4, 2017
agracio
pushed a commit
to agracio/edge-js
that referenced
this pull request
Sep 4, 2017
This was referenced Sep 4, 2017
|
@LiLinghui this solves AppDomain problem when running unit tests and when trying to forcefully run in new AppDomain using code, but on IIS/IIS Express Edge still throws AccessViolationException. Any chance you could take a look at it? |
vamsiak
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix doamin crash and add type:Dictionary<Int32, object> MarshalCLRToV8