-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto label to read version from .node-version #616
Conversation
(Errata: I included the version bump and changelog entry in this PR, which should not normally be included.) |
Released in |
This was a very very bad idea to merge and publish prior to getting agreement between version managers. By doing this, you'd likely poisoned |
Well @ljharb , years have gone by since discussions started and there were already multiple other implementations using I wanted to try the ideas for real, and the current implementation is consistent with the lowest common denominator discussed in the working group. I thought it was a pretty safe bet. If the working group decides on something else, then I can change to follow. |
There is never a safe bet, whether it takes weeks or decades, to "try out" a potential standard. |
Re-released using filename I look forward to seeing if there is any consensus on the potential standard. |
Pull Request
Problem
People would like to be able to specify the target version in a file, and have it read by their preferred node version manager. The commonly used generic filename is
.node-version
.Reference: nodejs/version-management#13
Solution
Read version number from
.node-version
and parse as if it had been given on command line. Be lenient with line endings, as I proposed in nodejs/version-management#13Use the label
auto
, as used bynvs
for this purpose.