feat: rework promise interface #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the promise `.then` to be greatly simplified. As part of this, error handling has also been improved in a few ways: - Timeouts are now handled by an `AbortSignal` rather than the built-in `timeout` option, as there is currently no way to know if a proc was killed due to a timeout. - The last error is stored until we `await` the result, at which point, we will throw the stored error - We wait for the process to close before trying to read the output, in case it threw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the promise
.thento be greatly simplified.As part of this, error handling has also been improved in a few ways:
AbortSignalrather than the built-intimeoutoption, as there is currently no way to know if a proc was killed due to a timeout.awaitthe result, at which point, we will throw the stored error