Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32bit testing #2840

Closed
wants to merge 2 commits into from
Closed

Fix 32bit testing #2840

wants to merge 2 commits into from

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented May 9, 2022

Or really, it's more of a workaround, by simply disabling the tests that can't run, as mentioned in #2824.

QuLogic added 2 commits July 21, 2022 01:56
Because Seek is not fully implemented there.
* compress/flate runs out of memory
* testing/fstest uses Seek, which is not implemented there
@aykevl
Copy link
Member

aykevl commented Sep 1, 2022

The syscall.seek issue will be fixed by #3103.

I can reproduce the "out of memory" issue on my laptop though:

$ GOARCH=arm tinygo test -v compress/flate
panic: runtime error: out of memory
qemu: uncaught target signal 6 (Aborted) - core dumped
FAIL    compress/flate  1337.215s
FAIL

Not sure what's causing it, as both amd64 and 386 should have a heap size of 1GB. Also, I don't see why compress/flate would use such a large amount of RAM during tests. Perhaps the GC has too many false positives so it keeps memory around?

@QuLogic
Copy link
Contributor Author

QuLogic commented Oct 28, 2024

I no longer do any 32-bit builds, so not sure what to do with this PR; maybe just close it?

@deadprogram
Copy link
Member

Given the age of the PR and the content, I will close. We can open something new should we pursue this.

Thank you everyone!

@QuLogic QuLogic deleted the fix-32bit branch October 28, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants