Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call scheduler from resume #1102

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

bradleypeabody
Copy link
Contributor

Adding scheduler call per discussion with @jaddr2line here #1091 resolves the issue where JS event handlers are not executing anything. I tested this on two examples which were exhibiting the bug and both are working now.

@aykevl
Copy link
Member

aykevl commented May 12, 2020

This looks reasonable to me, @jaddr2line can you perhaps double check that this is correct?

(I'm not sure how we could test for this, as we don't have any Go/JS tests right now)

@aykevl aykevl requested a review from niaow May 12, 2020 14:04
@bradleypeabody
Copy link
Contributor Author

Fwiw on Vugu I used this https://hub.docker.com/r/chromedp/headless-shell/ as a headless browser, made a little test server program and then serve up sample wasm programs into the headless browser click around on them with https://github.com/chromedp/chromedp - that works pretty well. I could take a crack at trying to set this up for tinygo with a few small test cases to start. I believe the above pieces would be the only requirements and would only be needed for testing. Is this worth looking into?

@deadprogram
Copy link
Member

That sounds like a very cool set of integration tests to me!

Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be fine?

@aykevl aykevl merged commit 29ca114 into tinygo-org:dev May 16, 2020
@aykevl
Copy link
Member

aykevl commented May 16, 2020

@jaddr2line thanks, just wanted to make sure I didn't miss anything important (as it seems like the kind of thing that could break in subtle ways).

@niaow niaow added this to the v0.14 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants