Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard library tests #110

Closed
wants to merge 1 commit into from
Closed

Standard library tests #110

wants to merge 1 commit into from

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Sep 3, 2020

This is a draft because only a handful of packages actually pass the tests with local patches to TinyGo. Those patches should soon end up in a TinyGo PR. This PR is only ready when a reasonable number of packages pass tests: most fail right now not because the package doesn't work but rather because tinygo test is incomplete.

@dkegel-fastly
Copy link
Contributor

This looks really good as is. I can enhance it after it lands.

The only nit I can see is: when a package has no tests, it should probably get an n/a rather than a yes in the "passes tests" column.

@aykevl aykevl marked this pull request as ready for review March 2, 2022 18:55
@aykevl
Copy link
Member Author

aykevl commented Mar 2, 2022

Marked the PR as ready for review.

The only nit I can see is: when a package has no tests, it should probably get an n/a rather than a yes in the "passes tests" column.

Agreed. Not entirely sure how to implement this though, currently it just looks whether the tinygo test process exited with an error or not. I guess this can be implemented later.

@aykevl
Copy link
Member Author

aykevl commented Mar 2, 2022

Another possible enhancement: run the tests for various platforms (Linux, wasi, cortex-m-qemu, maybe wasm or other OSes in the future). And display it in a nice table, of course.

@dkegel-fastly
Copy link
Contributor

dkegel-fastly commented Mar 2, 2022

I was thinking of just exposing the tests that are enforced by CI;
"make report-stdlib-tests-pass" in
tinygo-org/tinygo#2659
generates a nice table of those vs darwin, linux, wasi, and windows.

@dkegel-fastly
Copy link
Contributor

Oh, also, we might want to put an asterisk on the "passes tests" column to say that not all functions may be implemented yet... thinking of net and reflect, for instance.

@aykevl
Copy link
Member Author

aykevl commented Sep 4, 2022

This is now supported.

@aykevl aykevl closed this Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants