Skip to content

New base class for transforms #835

Merged
merged 23 commits into from
Aug 19, 2022
Merged

New base class for transforms #835

merged 23 commits into from
Aug 19, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Aug 4, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #797.

Closing issues

Closes #797

@alex-hse-repository alex-hse-repository self-assigned this Aug 4, 2022
@alex-hse-repository alex-hse-repository marked this pull request as draft August 4, 2022 06:36
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🚀 Deployed on https://deploy-preview-835--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 4, 2022 06:38 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (tsdataset_2@dc8d48a). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             tsdataset_2     #835   +/-   ##
==============================================
  Coverage               ?   84.10%           
==============================================
  Files                  ?      125           
  Lines                  ?     7281           
  Branches               ?        0           
==============================================
  Hits                   ?     6124           
  Misses                 ?     1157           
  Partials               ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alex-hse-repository alex-hse-repository marked this pull request as ready for review August 5, 2022 11:51
@github-actions github-actions bot temporarily deployed to pull request August 5, 2022 11:55 Inactive
etna/transforms/base.py Outdated Show resolved Hide resolved
@alex-hse-repository alex-hse-repository marked this pull request as draft August 10, 2022 05:24
@github-actions github-actions bot temporarily deployed to pull request August 15, 2022 07:24 Inactive
@alex-hse-repository alex-hse-repository marked this pull request as ready for review August 17, 2022 07:31
@github-actions github-actions bot temporarily deployed to pull request August 17, 2022 07:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 17, 2022 09:27 Inactive
@alex-hse-repository alex-hse-repository linked an issue Aug 17, 2022 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pull request August 17, 2022 14:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 04:23 Inactive
It is recommended to add the exogenous regressor using the constructor of the TSDataset.
This method does not add the regressors as exogenous data in df_exog, but only update the df attribute.
Before updating columns in df, columns of df_update will be cropped by the last timestamp in df.
If columns in df_exog are not updated. If you wish to update the df_exog, create the new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo remains. As I remember you meant "Columns in df_exog are not updated"

@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 07:24 Inactive
@alex-hse-repository alex-hse-repository merged commit 1d1dc51 into tsdataset_2 Aug 19, 2022
alex-hse-repository added a commit that referenced this pull request Sep 1, 2022
alex-hse-repository added a commit that referenced this pull request Feb 2, 2023
alex-hse-repository added a commit that referenced this pull request Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DRAFT]Make base class of Transforms work with TSDataset
3 participants