Skip to content

Add deep copy for copying attributes of TSDataset #1241

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 24, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #808.

Closing issues

Closes #808.

@Mr-Geekman Mr-Geekman self-assigned this Apr 24, 2023
@Mr-Geekman Mr-Geekman changed the title Add deepcopy for copying attributes of TSDataset Add deep copy for copying attributes of TSDataset Apr 24, 2023
@@ -24,17 +25,13 @@ def get_residuals(forecast_df: pd.DataFrame, ts: "TSDataset") -> "TSDataset":

Returns
-------
new_ts: TSDataset
new_ts:
TSDataset with residuals in forecasts

Raises
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how should this function work if there are target components and hierarchy.

I also found that make_future doesn't handle target components and hierarchy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can document constraints here

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

@github-actions github-actions bot temporarily deployed to pull request April 24, 2023 14:07 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #1241 (adf9ea0) into master (f06cd82) will decrease coverage by 0.18%.
The diff coverage is 94.73%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   87.92%   87.74%   -0.18%     
==========================================
  Files         186      186              
  Lines       10621    10623       +2     
==========================================
- Hits         9338     9321      -17     
- Misses       1283     1302      +19     
Impacted Files Coverage Δ
etna/analysis/forecast/utils.py 62.06% <90.00%> (+0.95%) ⬆️
etna/datasets/tsdataset.py 92.89% <100.00%> (+0.02%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martins0n martins0n self-requested a review April 25, 2023 07:41
martins0n
martins0n previously approved these changes Apr 25, 2023
@@ -24,17 +25,13 @@ def get_residuals(forecast_df: pd.DataFrame, ts: "TSDataset") -> "TSDataset":

Returns
-------
new_ts: TSDataset
new_ts:
TSDataset with residuals in forecasts

Raises
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can document constraints here

@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 13:55 Inactive
@Mr-Geekman Mr-Geekman requested a review from martins0n April 25, 2023 15:26
@Mr-Geekman Mr-Geekman merged commit 17a9c04 into master Apr 25, 2023
@Mr-Geekman Mr-Geekman deleted the issue-808 branch April 25, 2023 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Make deep copy of attributes during creation of a new TSDataset
3 participants