-
Notifications
You must be signed in to change notification settings - Fork 82
Add deep copy for copying attributes of TSDataset
#1241
Conversation
TSDataset
TSDataset
@@ -24,17 +25,13 @@ def get_residuals(forecast_df: pd.DataFrame, ts: "TSDataset") -> "TSDataset": | |||
|
|||
Returns | |||
------- | |||
new_ts: TSDataset | |||
new_ts: | |||
TSDataset with residuals in forecasts | |||
|
|||
Raises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand how should this function work if there are target components and hierarchy.
I also found that make_future
doesn't handle target components and hierarchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can document constraints here
🚀 Deployed on https://deploy-preview-1241--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 87.92% 87.74% -0.18%
==========================================
Files 186 186
Lines 10621 10623 +2
==========================================
- Hits 9338 9321 -17
- Misses 1283 1302 +19
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -24,17 +25,13 @@ def get_residuals(forecast_df: pd.DataFrame, ts: "TSDataset") -> "TSDataset": | |||
|
|||
Returns | |||
------- | |||
new_ts: TSDataset | |||
new_ts: | |||
TSDataset with residuals in forecasts | |||
|
|||
Raises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can document constraints here
Before submitting (must do checklist)
Proposed Changes
Look #808.
Closing issues
Closes #808.