Add params_to_tune for SeasonalMovingAverageModel, MovingAverageModel, NaiveModel and DeadlineMovingAverageModel
#1208
Conversation
…rageModel, NaiveModel and DeadlineMovingAverageModel
|
🚀 Deployed on https://deploy-preview-1208--etna-docs.netlify.app |
etna/models/deadline_ma.py
Outdated
| @@ -40,7 +47,8 @@ def __init__(self, window: int = 3, seasonality: str = "month"): | |||
| Only allowed monthly or annual seasonality. | |||
| """ | |||
| self.window = window | |||
| self.seasonality = SeasonalityMode(seasonality) | |||
| self.seasonality = seasonality | |||
| self._seasonality = SeasonalityMode(seasonality) | |||
There was a problem hiding this comment.
This is done because to_dict works incorrectly with enums. We should probably fix this somehow, but here I made a simple fix.
There was a problem hiding this comment.
May you add issue about it and TODO here
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## automl-2.0 #1208 +/- ##
=============================================
Coverage ? 69.07%
=============================================
Files ? 177
Lines ? 10522
Branches ? 0
=============================================
Hits ? 7268
Misses ? 3254
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
etna/models/deadline_ma.py
Outdated
| @@ -40,7 +47,8 @@ def __init__(self, window: int = 3, seasonality: str = "month"): | |||
| Only allowed monthly or annual seasonality. | |||
| """ | |||
| self.window = window | |||
| self.seasonality = SeasonalityMode(seasonality) | |||
| self.seasonality = seasonality | |||
| self._seasonality = SeasonalityMode(seasonality) | |||
There was a problem hiding this comment.
May you add issue about it and TODO here
Before submitting (must do checklist)
Proposed Changes
Look at #1193.
Closing issues
Closes #1193.