Skip to content

Fix order of columns after to flatten #1095

Merged

Conversation

GooseIt
Copy link
Contributor

@GooseIt GooseIt commented Feb 5, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

It may be useful to impose the same order on the return dataframe of .to_dataset() for the sake of consistency. Current order of columns in the return dataframe of ._to_dataset() places "target" along other features in alphabetical order.

Closing issues

closes #873

@GooseIt
Copy link
Contributor Author

GooseIt commented Feb 5, 2023

The "Proposed Changes" paragraph may be misleading.
The pull requests solves all problems and only those problems outlined in issue#873.
I wrote "Proposed Changes" as a statement of what can be further done in the direction established by issue#873 after the issue is closed. If I was wrong in doing this, please inform me.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #1095 (71ddc29) into master (d65999e) will decrease coverage by 18.53%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1095       +/-   ##
===========================================
- Coverage   86.96%   68.44%   -18.53%     
===========================================
  Files         170      170               
  Lines        9324     9321        -3     
===========================================
- Hits         8109     6380     -1729     
- Misses       1215     2941     +1726     
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 74.94% <100.00%> (-16.96%) ⬇️
etna/commands/__main__.py 0.00% <0.00%> (-87.50%) ⬇️
etna/datasets/hierarchical_structure.py 22.01% <0.00%> (-75.23%) ⬇️
etna/libs/pmdarima_utils/arima.py 28.84% <0.00%> (-71.16%) ⬇️
etna/pipeline/assembling_pipelines.py 26.31% <0.00%> (-71.06%) ⬇️
etna/pipeline/mixins.py 31.42% <0.00%> (-67.62%) ⬇️
etna/analysis/outliers/hist_outliers.py 10.82% <0.00%> (-66.25%) ⬇️
etna/reconciliation/bottom_up.py 35.29% <0.00%> (-64.71%) ⬇️
etna/auto/optuna/config_sampler.py 32.25% <0.00%> (-62.91%) ⬇️
etna/models/deadline_ma.py 35.18% <0.00%> (-59.26%) ⬇️
... and 59 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mr-Geekman
Copy link
Contributor

Could you please run make format command to fix linting ci stage?

@Mr-Geekman Mr-Geekman self-requested a review February 6, 2023 07:18
@Mr-Geekman
Copy link
Contributor

Proposed Changes section is about what is done inside PR, not about what we want to do in the future. I agree that it can be unclear, I usually just leave a link to the issue in this section.

@GooseIt
Copy link
Contributor Author

GooseIt commented Feb 6, 2023

Fixed issues with codestyle and ran 'make format' command

@GooseIt GooseIt requested a review from Mr-Geekman February 6, 2023 15:37
@GooseIt GooseIt requested a review from Mr-Geekman February 7, 2023 12:46
CHANGELOG.md Outdated Show resolved Hide resolved
@GooseIt GooseIt requested a review from Mr-Geekman February 7, 2023 14:15
@Mr-Geekman Mr-Geekman merged commit da08758 into tinkoff-ai:master Feb 7, 2023
@GooseIt GooseIt deleted the fix_order_of_columns_after_to_flatten branch February 22, 2023 17:10
@GooseIt GooseIt restored the fix_order_of_columns_after_to_flatten branch February 22, 2023 17:10
@GooseIt GooseIt deleted the fix_order_of_columns_after_to_flatten branch February 22, 2023 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix order of columns after TSDataset.to_flatten
3 participants