-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update webpack 4.0 #26
Conversation
Travis tests have failedHey @jimexist, Node.js: 8lerna run test
Node.js: 6lerna run test
|
Travis tests have failedHey @jimexist, Node.js: 6lerna run test
|
/** | ||
* Retrieves the public path from the loader options, context.options (webpack <4) or context._compilation (webpack 4+). | ||
* context._compilation is likely to get removed in a future release, so this whole function should be removed then. | ||
* See: https://github.com/peerigon/extract-loader/issues/35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking maybe we should add an option (e.g. publicPath
) to mina-loader
, if we can't access the context.options
or context._compilation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although most of the time our users will keep it as "/"
.
Travis tests have failedHey @jimexist, Node.js: 8lerna run test
Node.js: 6lerna run test
|
- use webpack `none` mode for testing - use @tinajs/wxml-loader instead of wxml-loader temporarily
- use `compiler.hooks[name].tap(...)` instead of `compiler.plugin(name, ...)` - use `func.apply(compiler)` instead of `compiler.apply(func)` - update the params of `compiler.hooks.watchRun`
- deprecate `runtime` option - load filename of runtime and common chunks automaticly - use `output.globalObject`
Hey @jimexist, |
- @tinajs/[email protected] - @tinajs/[email protected] - @tinajs/[email protected] - @tinajs/[email protected]
Hey @jimexist, |
Hey @jimexist, |
fixes #24
currently blocked by Cap32/wxml-loader#12