Skip to content

Commit

Permalink
Remove the obsolete needle dependency
Browse files Browse the repository at this point in the history
The `needle` dependency originally got introduced in mozilla#12024, almost four
years ago, to be able to use pre-built binaries for the `canvas`
dependency on macOS. However, nowadays the `needle` dependency isn't
used by `canvas` anymore, or any other package we use for that matter,
as shown by the empty NPM dependency tree:

```
$ npm ls needle
pdf.js
└── [email protected]
```

Investigation showed that the `canvas` package depends on the
`node-pre-gyp` package which in turn depended on `needle` (see
Automattic/node-canvas#1110 (comment)),
but in version 1.0.0 of `node-pre-gyp` from three years ago the `needle`
dependency got dropped in favor of `node-fetch`. This explains why the
NPM dependency tree is empty now and proves that we can safely get rid
of this dependency.
  • Loading branch information
timvandermeij committed May 16, 2024
1 parent e8e9a3e commit 289b5c9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 42 deletions.
41 changes: 0 additions & 41 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"jsdoc": "^4.0.3",
"jstransformer-markdown-it": "^3.0.0",
"merge-stream": "^2.0.0",
"needle": "^3.3.1",
"path2d": "^0.2.0",
"pngjs": "^7.0.0",
"postcss": "^8.4.38",
Expand Down

0 comments on commit 289b5c9

Please sign in to comment.