Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed adjustments to let the module working #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

coderpussy
Copy link

General:

  • Adjusted README.md
  • Renamed module files to keep persistent naming

MMM-MPD.js:

  • Adjusted related includings for css and js

node_helper.js:

  • Added missing require for node helper
  • Small adjustment on playlist parsing in case of different mpd file array sorting
  • Changed mpd client reaction from system-player to system
    • system have all the time changes in mpd server present
    • helps to let mirror module display instantly mpd changes

- Adjusted related includings css and js
- Added missing require for node helper in node helper files
- Adjusted playlist parsing in case of different mpd file array sorting
- Changed mpd client reaction from system-player to system
    - system have all the time changes in mpd server present
    - helps to let mirror module display instantly mpd changes
- Added translation for german and english
- Workaround loop logic for parsing playlist
  (file url can be at the end in array)
- Added config variable to enable track listing
- Added config variable to enable playlist fading effect
- Adjusted README.md
- Adjusted css styles
Commented out console.log messages.
- Added css styles for progress bar
- Set module width to fixed size
- Adjusted template structure
- Added new screenshot to README.md
@dnj0104
Copy link

dnj0104 commented Oct 23, 2020

-SOLVED-

Hello have installed this wonderful module but it fails to load
have found some error today. 23 october 23:39 stockholm/berlin time.

if change folder name mmm-mpd to mpd_client errors in MM startup:

alerts in MagicMirror startup:
WARNING! Could not validate config file. Starting with default configuration. Please correct syntax errors at or above this line: ReferenceError: NodeHelper is not defined at Object.<anonymous> (/home/pi/MagicMirror/modules/mpd_client/node_helper.js:4:18) at Module._compile (internal/modules/cjs/loader.js:786:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10) at Module.load (internal/modules/cjs/loader.js:645:32) at Function.Module._load (internal/modules/cjs/loader.js:560:12) at Module.require (internal/modules/cjs/loader.js:685:19) at require (internal/modules/cjs/helpers.js:16:16) at loadModule (/home/pi/MagicMirror/js/app.js:134:17) at loadNextModule (/home/pi/MagicMirror/js/app.js:169:5) at /home/pi/MagicMirror/js/app.js:171:6

change folder name from mmm-mpd to mpd-client:
Result: No errors in MM-startup but mpd-module does not start.

Looking for errors in MM-dev tools with folder named to mpd-module:
Errors: Load script: modules/mpd_client//mpd_client.js :8080/modules/mpd_cl…nt//mpd_client.js:1 Failed to load resource: the server responded with a status of 404 (Not Found) loader.js:186 Error on loading script: modules/mpd_client//mpd_client.js

module in mm-config array looks like
this.

module: "mpd_client", position: "top_right", // This can be any of the regions. config: { // See 'Configuration options' for more information. hostname:"mpd@moodeaudio@rpi3b+)", port:6600

@dnj0104
Copy link

dnj0104 commented Oct 23, 2020

-SOLVED-

also tried to rename folder, js file and cssfile to mod insted of mpd, as it should be regarding devs att MagicMirror forum , but it still not works, the result is if I change anything in mmm-mpd folders or config array my screen either turns black or mmm-mpd doesnt start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants