Circumvent CI hang on 1.8 #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#710 attempted to debug a Requires-based hang that seems to only occur on CI with Julia 1.8. It may be due to lock contention, but the precise case was not obvious. This just disables the problematic test. Since it doesn't happen on nightly, and since Requires will be supplanted by the new weakdeps mechanism, we can direct any users who encounter this bug to the alternatives.
|
CC @t-bltg |
|
These failures are different and will be fixed by JI#561. Looks like I pushed this just a few minutes before a new JuliaInterpreter was registered. |
Closed
|
Yes, it's probably best if we can move forward, and rework if we encounter a real case scenario bug related to this.
Let's rerun ci ? EDIT: relaunched |
|
This does not seem to be a regression, so let's merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#710 attempted to debug a Requires-based hang that seems
to only occur on CI with Julia 1.8. It may be due to lock contention,
but the precise cause was not obvious.
This just disables the problematic test.
Since it doesn't happen on nightly, and since Requires will be
supplanted by the new weakdeps mechanism, we can direct any
users who encounter this bug to the alternatives.