Add ci check for idempotency in sql scripts #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabriziomello, @erimatnor: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7624 +/- ##
==========================================
+ Coverage 80.06% 81.31% +1.25%
==========================================
Files 190 240 +50
Lines 37181 44700 +7519
Branches 9450 11159 +1709
==========================================
+ Hits 29770 36350 +6580
- Misses 2997 3962 +965
+ Partials 4414 4388 -26 ☔ View full report in Codecov by Sentry. |
antekresic
approved these changes
Jan 27, 2025
svenklemm
force-pushed
the
update_checks
branch
4 times, most recently
from
db8a565 to
3ded0d2
Compare
To detect the problematic patterns that were part of the 2.18 release we can check the sql scripts against a list of allowed statements. Any non idempotent operation should be in the pre_install scripts and not the scripts that get appended for the update scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect the problematic patterns that were part of the 2.18 release
we can check the sql scripts against a list of allowed statements.
Any non idempotent operation should be in the pre_install scripts
and not the scripts that get appended for the update scripts.
Disable-check: approval-count
Disable-check: force-changelog-file