Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put vectorized aggregation results in short-lived memory context #7461

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Nov 19, 2024

It is enough to use the per-tuple context for them, now they end up in the ExecutorState context which is incorrect.

Disable-check: force-changelog-file

It is enough to use the per-tuple context for them, now they end up in
the ExecutorState context which is incorrect.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (59f50f2) to head (f723cf5).
Report is 613 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/nodes/vector_agg/exec.c 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7461      +/-   ##
==========================================
+ Coverage   80.06%   82.12%   +2.05%     
==========================================
  Files         190      230      +40     
  Lines       37181    43110    +5929     
  Branches     9450    10830    +1380     
==========================================
+ Hits        29770    35404    +5634     
- Misses       2997     3396     +399     
+ Partials     4414     4310     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@akuzm akuzm mentioned this pull request Nov 19, 2024
10 tasks
@akuzm akuzm enabled auto-merge (squash) November 21, 2024 10:28
@akuzm akuzm merged commit 399b11a into timescale:main Nov 21, 2024
49 of 50 checks passed
@akuzm akuzm deleted the partial-context branch November 21, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants