Remove superfluous checks in partialize_agg

[svenklemm]

Remove checks that will always return true in current implementation to make refactoring easier. Aggref->args will always be list of TargetEntry, and the bulk_decompression check will always return true as well.

Disable-check: force-changelog-file

[github-actions]

@mkindahl, @mahipv: please review this pull request.

Powered by pull-review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1c8cb0) 65.44% compared to head (53c7b96) 65.39%.
Report is 2 commits behind head on main.

❗ Current head 53c7b96 differs from pull request most recent head 6c081dd. Consider uploading reports for the commit 6c081dd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6327      +/-   ##
==========================================
- Coverage   65.44%   65.39%   -0.05%     
==========================================
  Files         249      249              
  Lines       57984    57916      -68     
  Branches    12918    12891      -27     
==========================================
- Hits        37946    37876      -70     
- Misses      18198    18201       +3     
+ Partials     1840     1839       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jnidzwetzki]

@svenklemm Could you elaborate what kind of refactoring this function is currently preventing?

It is correct, the function never returns false currently. However, the function is part of the initiative to make the vectoized sum() aggregation implementation more generic and introduce infrastructure for all kinds of aggregates. As soon as we support more data types, we need this kind of check in the planner.

[svenklemm]

Any code that references FormData_hypertable_compression needs to be adjusted cause the corresponding table is gonna get removed. The structure of the new settings will also be very different (no more positional indexes) so any place that references it now usually needs quite a few changes.

[svenklemm]

If we depend on this providing the correct answer about used algorithm the current implementation is insufficient. To get a definitive answer about algorithms used you have to check the batch header as the compressor will deviate from whatever is stored in Hypertable_compression.