Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display of timezone for datetime and datetime64 #838

Merged
merged 8 commits into from
Oct 19, 2024
Merged

Support display of timezone for datetime and datetime64 #838

merged 8 commits into from
Oct 19, 2024

Conversation

Jasmine-ge
Copy link
Contributor

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
close #835

@Jasmine-ge Jasmine-ge added the enhancement New feature or request label Sep 27, 2024
@Jasmine-ge Jasmine-ge requested a review from yl-lisen September 27, 2024 10:15
@Jasmine-ge Jasmine-ge self-assigned this Sep 27, 2024
@Jasmine-ge Jasmine-ge added pr-test and removed enhancement New feature or request labels Sep 27, 2024
yl-lisen
yl-lisen reviewed Sep 27, 2024
View reviewed changes
yl-lisen
yl-lisen reviewed Sep 27, 2024
View reviewed changes
yl-lisen
yl-lisen reviewed Sep 27, 2024
View reviewed changes
yl-lisen
yl-lisen reviewed Sep 27, 2024
View reviewed changes
yl-lisen
yl-lisen reviewed Oct 11, 2024
View reviewed changes
yl-lisen
yl-lisen reviewed Oct 11, 2024
View reviewed changes
@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch from c3e0aa5 to 5e323f3 Compare October 11, 2024 07:37
@jovezhong
Copy link
Contributor

I would suggest creating build 1.6.1 after this PR is merged, since it will change how the datetime with explicit timezone will be displayed in console and to_string function. Too many patch build for 1.5.x already and this change need a bit more attention.

@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch 2 times, most recently from d906402 to 47efacb Compare October 17, 2024 07:00
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch from 47efacb to 11f2a4f Compare October 17, 2024 07:23
@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch from 11f2a4f to a775e6c Compare October 18, 2024 05:50
@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch from a775e6c to 7ea7940 Compare October 18, 2024 05:51
@Jasmine-ge Jasmine-ge force-pushed the enhancement/issue-835-display-timezone-information-for-datetime branch from 7ea7940 to b3b218c Compare October 18, 2024 05:55
@yl-lisen yl-lisen merged commit abab246 into develop Oct 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candlerb candlerb candlerb left review comments

@yl-lisen yl-lisen yl-lisen approved these changes

Assignees

@Jasmine-ge Jasmine-ge

Labels
pr-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display timezone information for datetime
5 participants
@Jasmine-ge @jovezhong @CLAassistant @candlerb @yl-lisen