Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly hotfix for "terminate on uncaught exception" in WriteBufferFromO… #622

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Ugly hotfix for "terminate on uncaught exception" in WriteBufferFromO… #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dfd9c2
Ugly hotfix for "terminate on uncaught exception" in WriteBufferFromO…
yokofly Mar 21, 2024
c7524d8
Merge branch 'develop' into bugfix/issue-621-skip-exception-in-dtor
yokofly Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/IO/WriteBufferFromOStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <IO/WriteBufferFromOStream.h>

#include <Common/logger_useful.h>

namespace DB
{
Expand All @@ -18,8 +18,14 @@ void WriteBufferFromOStream::nextImpl()
ostr->flush();

if (!ostr->good())
throw Exception("Cannot write to ostream at offset " + std::to_string(count()),
ErrorCodes::CANNOT_WRITE_TO_OSTREAM);
{
/// FIXME do not call finalize in dtors (and remove iostreams)
bool avoid_throwing_exceptions = std::uncaught_exceptions();
if (avoid_throwing_exceptions)
LOG_ERROR(&Poco::Logger::get("WriteBufferFromOStream"), "Cannot write to ostream at offset {}. Stack trace: {}", count(), StackTrace().toString());
else
throw Exception(ErrorCodes::CANNOT_WRITE_TO_OSTREAM, "Cannot write to ostream at offset {}", count());
}
}

WriteBufferFromOStream::WriteBufferFromOStream(
Expand Down
Loading