-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 590 improve the fault tolerance of materialized view #597
Enhancement/issue 590 improve the fault tolerance of materialized view #597
Conversation
5d1834a
to
ee6f1a9
Compare
|
||
Int64 lastCheckpointedSN() const noexcept { return last_checkpointed_sn; } | ||
|
||
void checkpoint(CheckpointContextPtr ckpt_ctx_) override final; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make checkpoint
non virtual and remove the checkpoint, recover
interface from DB::ISource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the checkpoint/recover
virtual interface is defined in IProcessor
b296a23
to
a718cc6
Compare
resolve #590 and close #598
Please write user-readable short description of the changes:
DB::Streaming::ISource
RecoveryPolicy
via a settingsettings recovery_policy='strict' or 'best_effort'
:If we need know what's the dirty data, we can use the following statement to query data within the specified sn range
(checkpointed_sn, processed_sn]
:Usually, the data at
processed_sn
is the cause of the error