-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streaming processing supports nullable datatype #594
Merged
lizhou1111
merged 4 commits into
develop
from
feature/issue-422-streaming-processing-supports-nullable-datatype
Mar 15, 2024
Merged
streaming processing supports nullable datatype #594
lizhou1111
merged 4 commits into
develop
from
feature/issue-422-streaming-processing-supports-nullable-datatype
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f03ffbd
to
a14d8be
Compare
lizhou1111
commented
Mar 12, 2024
a14d8be
to
2450404
Compare
yl-lisen
reviewed
Mar 14, 2024
yl-lisen
reviewed
Mar 14, 2024
yl-lisen
reviewed
Mar 14, 2024
yl-lisen
reviewed
Mar 14, 2024
2450404
to
3f82357
Compare
yl-lisen
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, don't close #422 , it's an initial PR , we can merge it first
Next, we need do more nullable type supporting or checking for functions / other processing via following PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is for supporting nullable data type in streaming processing.Actually proton had already supported the nullable data type, but it had some bugs. Full test report:Nullable datatype in streaming processing test report.
Bug 1: group by window_start and nullable column.
For example:
It won’t output any result.
Bug 2: when you create external stream with nullable column, in some data type it will lose data.
For example:
Current progress:
For bug2, if a columns are nullable, there are 4 situation about inserting data in redpanda
In the former proton, proton will discard the whole message for 3 and 4(bug 2), now it only happen in 4(Maybe this shouldn't happen either?).