fix random stream eps incorrect #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lizhou1111
force-pushed
the
bugfix/issue-456-fix-random-stream-eps-incorrect
branch
3 times, most recently
from
b8e5b9a to
72c759d
Compare
lizhou1111
deleted the
bugfix/issue-456-fix-random-stream-eps-incorrect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this close #456
It is a logical error.The dividing point that causes a bug is
max_block_size.If eps <max_block, it is ok, else, it will be incorrect eps.Now it can generage exactly eps you want.
A small fixme: if the batch size generated in one interval is bigger than max block size, you have to split it into small batch.I will do it soon