Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix external stream metrics format #445

Merged
merged 3 commits into from
Dec 28, 2023
Merged

fix external stream metrics format #445

merged 3 commits into from
Dec 28, 2023

Conversation

qijun-niu-timeplus
Copy link
Collaborator

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

@qijun-niu-timeplus
Copy link
Collaborator Author 

# TYPE ProtonExternalStream_ReadBytes counter
ProtonExternalStream_ReadBytes{database="default", name="test1"} 16
# TYPE ProtonExternalStream_ReadCounts counter
ProtonExternalStream_ReadCounts{database="default", name="test1"} 1
# TYPE ProtonExternalStream_ReadFailed counter
ProtonExternalStream_ReadFailed{database="default", name="test1"} 0

@yokofly yokofly linked an issue Dec 28, 2023 that may be closed by this pull request
the label for the metrics of external stream is not valid #437
Closed
@yokofly yokofly merged commit c8e0806 into develop Dec 28, 2023
18 checks passed
@yokofly yokofly deleted the bugfix/issue-437-fix-external-stream-metrics-format branch December 28, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokofly yokofly yokofly approved these changes

@ye11ow ye11ow Awaiting requested review from ye11ow

@yl-lisen yl-lisen Awaiting requested review from yl-lisen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the label for the metrics of external stream is not valid
2 participants
@qijun-niu-timeplus @yokofly