-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mac m1/x86 build err #94
Comments
must porting:
click mediff --git a/v8/src/trap-handler/handler-inside-posix.cc b/v8/src/trap-handler/handler-inside-posix.cc
index dba47ec7..3427315c 100644
--- a/v8/src/trap-handler/handler-inside-posix.cc
+++ b/v8/src/trap-handler/handler-inside-posix.cc
@@ -47,7 +47,11 @@ namespace v8 {
namespace internal {
namespace trap_handler {
-#if V8_OS_LINUX
+#if V8_OS_LINUX && V8_HOST_ARCH_ARM64
+#define CONTEXT_PC() &uc->uc_mcontext.pc
+#elif V8_OS_DARWIN && V8_HOST_ARCH_ARM64
+#define CONTEXT_PC() &uc->uc_mcontext->__ss.__pc
+#elif V8_OS_LINUX
#define CONTEXT_REG(reg, REG) &uc->uc_mcontext.gregs[REG_##REG]
#elif V8_OS_DARWIN
#define CONTEXT_REG(reg, REG) &uc->uc_mcontext->__ss.__##reg
@@ -125,7 +129,7 @@ bool TryHandleSignal(int signum, siginfo_t* info, void* context) {
#if V8_HOST_ARCH_X64
auto* context_ip = CONTEXT_REG(rip, RIP);
#elif V8_HOST_ARCH_ARM64
- auto* context_ip = &uc->uc_mcontext.pc;
+ auto* context_ip = CONTEXT_PC();
#else
#error "Unsupported architecture."
#endif
|
take 1: #157 |
I’m currently working on this and making steady progress. If you’d like to give it a try, please use the latest commit from the
(We aim to support the homebrew version of llvm/clang.) brew install ccache cmake ninja libtool gettext llvm@16 gcc binutils grep findutils libiconv
export CC=$(brew --prefix llvm@16)/bin/clang
export CXX=$(brew --prefix llvm@16)/bin/clang++
export PATH=$(brew --prefix llvm@16)/bin:$PATH
cd proton
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER=`which clang++` -DCMAKE_C_COMPILER=`which clang` -DENABLE_PROTON_ALL=OFF -DENABLE_PROTON_SERVER=ON -DENABLE_PROTON_CLIENT=ON -DENABLE_PROTON_FORMAT=ON -DENABLE_PROTON_INSTALL=OFF -DENABLE_PROTON_METASTORE=ON -DUSE_STATIC_LIBRARIES=ON -DUSE_UNWIND=OFF -DUSE_DEBUG_HELPERS=ON -DENABLE_LIBRARIES=OFF -DENABLE_KAFKA=ON -DENABLE_GRPC=ON -DENABLE_NURAFT=ON -DENABLE_RAPIDJSON=ON -DENABLE_YAML_CPP=ON -DENABLE_SIMDJSON=ON -DENABLE_ROCKSDB=ON -DENABLE_REPLXX=ON -DENABLE_JEMALLOC=OFF -DENABLE_SSL=ON -DENABLE_BZIP2=ON -DENABLE_PROTOBUF=ON -DENABLE_URING=ON -DENABLE_UTILS=OFF -DENABLE_THINLTO=OFF -DENABLE_CLANG_TIDY=OFF -DENABLE_TESTS=ON -DSTRIP_DEBUG_SYMBOLS_FUNCTIONS=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_CCACHE=ON -DENABLE_BUILD_PATH_MAPPING=OFF -DENABLE_CYRUS_SASL=ON -DENABLE_KRB5=ON -DENABLE_HIGH_ORDER_ARRAY_FUNCS=ON -DENABLE_MATH_FUNCS=ON -DENABLE_GEO_FUNCS=ON -DENABLE_PARQUET=ON -DENABLE_THRIFT=ON -DENABLE_EMBEDDED_COMPILER=ON -DENABLE_MISC_FUNCS=ON -DENABLE_HASH_FUNCS=ON -DENABLE_INTROSPECTION_FUNCS=ON -DENABLE_BROTLI=ON |
take 2: #178 |
status: or you personally merge the 2 PRs in your local and use llvm@16 from home brew to build proton.(make takes one hour). |
(Jove Github Bot) assuming it is not done, deferred this ticket to the next sprint. |
update v1: add x86 err point 123
update v2: add x86 err 3 workround
update v3: unsolved@add x86 and m1 err(m1 also contain some warning)
below is mac m1 err
1. curl need upgrade, and after upgrade, work.
Click me
2. azure sdk need modify random val generator, after modify to
#include<random>
instead stdlib random api, works.Click me
3. v8 build error
Click me
4. err not find symbol
Click me
5. build warning trash code for utils/wal-dump can be remove?
linking_warning.txt
below is mac x86 err
1. curl as previous
2. azure as previous
3. deprecated in
utils/db-generator/query_db_generator
tmp workround: ClickHouse/ClickHouse@5be30b9
in future? remove trash: ClickHouse/ClickHouse@8860550
Click me
4. err symbol not find same as above.
click me
How to reproduce
Error message and/or stacktrace
Additional context
The text was updated successfully, but these errors were encountered: